-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ClojureScript dep to profiles #65
Comments
I don't know the state of the code, but can we ensure that all the code works without cljs loaded, lest we end up with the same problem we have at piggieback. |
Well, that would be ideal, but it might be a bit harder here. When I agreed to baking the ClojureScript support in Orchard I didn't now many deps ClojureScript was pulling in (I assumed it didn't have any runtime deps). While that's not an issue for |
The clojurescript dependency cannot be obfuscated. Otherwise you won't be accessing the right clojurescript state (via the compiler env) |
Ah, yeah. Silly me. Well, I guess we'll figure something out. |
Piggieback solved this with a "shim" to only load cljs code when cljs was available. |
Run now we've hardcoded the dep, which is bad for end users. It should go to all profiles the way we've done for other projects (e.g. https://github.com/clojure-emacs/cider-nrepl/blob/master/project.clj).
@arichiardi The current code will work with older ClojureScript releases, right?
The text was updated successfully, but these errors were encountered: