Introduce ClojureScript compliment source #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arichiardi
changed the title
arichiardi
force-pushed
the
compliment-cljs
branch
from
e674bdd to
00c4443
Compare
arichiardi
changed the title
This patch introduce a new ClojureScript source for compliment. There are tests in there that are all passing except one (search for TODO).
|
Looks good, thank you! Also thanks for the heads up regarding the tests. Seems to be a timing issue with nashorn, once the cache is there or when run in debug mode it works. Will investigate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces a ClojureScript
defsourcefor compliment.It is a port of what was before into
cljs-tooling(kind of, as the code has been ported tocomplimentbefore that).The code contains tests that are current passing, with the exception of one -
commented out for future investigation with a
TODO.This PR needs to go in for us to fully take advantage of this:
alexander-yakushev/compliment#71
I have also noticed some of the old tests are not passing.
If you want to execute just
complimenttests you can run: