Add stacktrace navigator for clojure.spec/asserts #2082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Sep 17, 2017
cider-stacktrace.el
Outdated
| @@ -727,10 +726,53 @@ This associates text properties to enable filtering and source navigation." | |||
| (insert (propertize (format " at (%d:%d)" line column) | |||
| 'font-lock-face message-face)))))) | |||
|
|
|||
| (defun cider-stacktrace--insert-keyed-value (indent key &rest args) | |||
| "Insert KEY and ARGS prefixed by INDENT." | |||
| (let ((str (when args | |||
There was a problem hiding this comment.
The indentation is wrong here.
What's keyed value? From the usages of this it seems you're just passing some labels as "keys".
There was a problem hiding this comment.
That's the best name I could think of, but I hardly spend any time thinking about it. The idea is to be able to insert into the buffer a pair of objects - key and value. For example in the screenshot above in: is key and [:cljproj.core/email] is a value. If "value" is multi-line then all of those line should be indented.
In any case, will think of something better once I find time refresh on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clojure.spec/asserts are hard to read, especially in cider stacktrace browser. Adding specialized support for spec/asserts with the ability to toggle visibility of multi-line values.The visibility toggling is not fully integrated with the default cause-visibility-cycling in the stacktrace browser, mostly because the non-idiomatic usage of invisibility properties by
cider-stacktrace.el. Instead of modifyingbuffer-invisibility-spec, as intended by emacs design, it modifies buffer text properties directly. I might rewrite that part some day but it's low priority. For now it's unlikely that anyone will be bothered by this.Assuming that this will go into 0.16, so no doc entry as yet.