Apropos special forms #2012
Merged
Apropos special forms #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Jun 16, 2017
cider-grimoire.el
Outdated
| "Look up the grimoire documentation for SYMBOL." | ||
| "Look up the grimoire documentation for SYMBOL. | ||
|
|
||
| If SYMBOL is a special form, the `clojure.core' ns is used, as is |
There was a problem hiding this comment.
Don't quote clojure.core here - this is just for Elisp symbols.
|
You should also add a changelog entry. |
xiongtx
force-pushed
the
apropos-special-forms
branch
from
4ae60e0
to
79e6894
Compare
Add `apropos-special-form` button type Default to `clojure.core` ns for Grimoire; this is necessary for special forms, which do not have ns. Grimoire defaults to `clojure.core`.
xiongtx
force-pushed
the
apropos-special-forms
branch
from
79e6894
to
cf92441
Compare
|
What's your general rule for releasing new version of |
There are no special rules - I release new versions when it seems to me that this is warranted. Usually I aim to cut major releases around major Clojure conferences. |
xiongtx
added a commit
to clojure-emacs/helm-cider
that referenced
this pull request
Jun 17, 2017
See related PRs in cider-nrepl and CIDER: - clojure-emacs/cider-nrepl#410 - clojure-emacs/cider#2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are necessary to use clojure-emacs/cider-nrepl#409.
Example of special forms from
cider-apropos: