Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interactive function to flush Compliment caches #1943

Merged
merged 1 commit into from
Mar 7, 2017
Merged

Add interactive function to flush Compliment caches #1943

merged 1 commit into from
Mar 7, 2017

Conversation

alexander-yakushev
Copy link
Member

@@ -573,6 +573,10 @@ The formatting is performed by `cider-annotate-completion-function'."
:company-location #'cider-company-location
:company-docsig #'cider-company-docsig))))

(defun cider-completion-flush-caches ()
(interactive)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have a docstring. Otherwise pretty much no one would figure out what it does.

I'd also suggest mentioning this somewhere in the manual as I doubt anyone would find this command by themselves. It might also be added to some of the menus.

@bbatsov
Copy link
Member

bbatsov commented Feb 28, 2017

@alexander-yakushev ping :-)

@alexander-yakushev
Copy link
Member Author

alexander-yakushev commented Mar 1, 2017

Added a docstring, and a mention in the docs. Do you have a suggestion where in the menu I can put it? Right now Complete symbol is a separate item in the CIDER interaction menu. I'm reluctant to add a subtree to it just for this one minor function. Perhaps, we could use some subtree dumpster like Miscellaneous for these kinds of functions?

@bbatsov
Copy link
Member

bbatsov commented Mar 1, 2017 via email

@alexander-yakushev
Copy link
Member Author

Added a menu item under new "Misc" category.

@bbatsov
Copy link
Member

bbatsov commented Mar 7, 2017

@alexander-yakushev Don't forget to update the changelog as well.

@alexander-yakushev
Copy link
Member Author

Done :)

@bbatsov bbatsov merged commit 34dca8a into clojure-emacs:master Mar 7, 2017
@bbatsov
Copy link
Member

bbatsov commented Mar 7, 2017

👍

@bbatsov
Copy link
Member

bbatsov commented Mar 7, 2017

Now you have to finish that task you started about the inspector paths. ;-)

@alexander-yakushev
Copy link
Member Author

Nothing escapes you, Bozhidar! 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants