[Fix #1297] C-c M-n should act on both repls #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| (cons | ||
| (cider-other-connection (cider-current-connection)) | ||
| connections) | ||
| connections))) |
There was a problem hiding this comment.
Kinda minor nitpick, but I think it reads a little better if you remove the second binding and use this inside the let body.
(when (or (derived-mode-p 'clojurec-mode)
(derived-mode-p 'clojurex-mode))
(push (cider-other-connection (cider-current-connection))
connections))
There was a problem hiding this comment.
Oh, and it needs to account for the fact that (cider-other-connection (cider-current-connection)) might be nil.
expez
force-pushed
the
keep-dual-repls-in-sync
branch
from
46b5027
to
648f20c
Compare
Make `project-directory` optional in `cider-find-connection-buffer-for-project-directory`. The default value is found using `(clojure-project-dir)` starting at `(cider-current-dir)`. This is the most common use-case and should be made easy.
expez
force-pushed
the
keep-dual-repls-in-sync
branch
from
648f20c
to
caeb6d3
Compare
|
Rewritten to address all comments. Thanks guys :) |
expez
force-pushed
the
keep-dual-repls-in-sync
branch
from
caeb6d3
to
3b79b3f
Compare
|
👍 |
| @@ -220,6 +226,15 @@ file extension." | |||
| ;; TODO: Add logic to dispatch to a matching Clojure/ClojureScript REPL based on file type | |||
| (car cider-connections))) | |||
|
|
|||
| (defun cider-other-connection (connection) | |||
| "Return the first connection of another type than CONNECTION or nil." | |||
There was a problem hiding this comment.
Here it should say the connection has the same project.
|
This also needs a changelog entry. Sorry about the extra comments - I was interrupted while going though the code the previous time. |
| @@ -761,18 +761,26 @@ text property `cider-old-input'." | |||
| (defun cider-repl-set-ns (ns) | |||
| "Switch the namespace of the REPL buffer to NS. | |||
|
|
|||
| If invoked in a REPL buffer the command will prompt you for the name of the | |||
| If called from a cljc or cljx buffer act on both the Clojure and | |||
| ClojureScript REPL if there are more than one REPL present. | |||
There was a problem hiding this comment.
if there is more than one (otherwise it should be REPLs I think)
In a cljc or cljx buffer hitting `C-c M-n` to switch the repl ns will now act on both repls so they are in sync.
expez
force-pushed
the
keep-dual-repls-in-sync
branch
from
3b79b3f
to
e67be7e
Compare
bbatsov
added a commit
that referenced
this pull request
Nov 4, 2015
[Fix #1297] C-c M-n should act on both repls
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a cljc or cljx buffer hitting
C-c M-nto switch the repl ns will now act on both repls so they are in sync.