Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color symbols in the ns-browser like with cider-font-lock-dynamically #1561

Closed
Malabarba opened this issue Feb 13, 2016 · 0 comments
Closed

Color symbols in the ns-browser like with cider-font-lock-dynamically #1561

Malabarba opened this issue Feb 13, 2016 · 0 comments
Labels
enhancement

Comments

@Malabarba
Copy link
Member

As the title says, font-lock vars, macros, and functions in the ns-browser as they would be in a Clojure buffer.
@bbatsov bbatsov mentioned this issue Feb 13, 2016
Closed
@Malabarba Malabarba modified the milestone: The UX release (v0.12?) Feb 13, 2016
@Malabarba Malabarba modified the milestones: The UX release (v0.12?), v0.13.0 Apr 15, 2016
@ckoparkar ckoparkar mentioned this issue Apr 19, 2016
Merged
bbatsov pushed a commit that referenced this issue Apr 21, 2016
@cskksc @bbatsov
[#1561] Font-lock vars, macros, and functions in the ns-browser (#1695)
b145e3e 
Use each var's info from a running repl to decide a font-face.
ajchemist pushed a commit to ajchemist/cider that referenced this issue Apr 25, 2016
@cskksc @ajchemist
[clojure-emacs#1561] Font-lock vars, macros, and functions in the ns-…
d6f2a94 
…browser (clojure-emacs#1695)

Use each var's info from a running repl to decide a font-face.
ajchemist pushed a commit to ajchemist/cider that referenced this issue Apr 25, 2016
@cskksc @ajchemist
[Fix clojure-emacs#1561] Correct font-lock vars for namespaces not lo…
d2f525f 
…aded in the REPL (clojure-emacs#1710)

The current ns-browser relies on the `cider-repl-ns-cache` to decide font-locks. This gives us incorrect font-locks for namespaces which are present on the classpath, but not loaded in the REPL.
We change this to get the data from the nREPL middleware op `ns-vars-with-meta`,in case of a cache miss; clojure-emacs/cider-nrepl#346.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Malabarba