Regression in stacktrace font-locking #1486
Comments
|
It's amazing no one noticed this for over one year. |
|
You might want to mention the fix in the changelog as well. |
Update stack frame buttons to use `font-lock-face`. Create a button type that respects `font-lock-face`. By default, buttons use `'face`.
|
That's what I thought too. Maybe everyone is just conditioned to ugly errors. For all Clojure's awesomeness, errors are still not sane. On the other hand, the updates to CIDER in the last year are really fantastic. Seriously great stuff! |
…cking. Update stack frame buttons to use `font-lock-face`. Create a button type that respects `font-lock-face`. By default, buttons use `'face`.
|
I'm trying to test that this is fixed in the v0.10 branch, but I'm not 100% sure how to reproduce it. Can someone post some simple reproduction steps? Thanks! |
|
If the file, line number, namespace/class, and function/method for stacktrace frames all appear with the same face, you're seeing this issue. If the function name is in bold and the ns is fontified as a comment, you're seeing the fix. |
|
@jeffvalk Thanks, looks good in that case. |
401e819 changed uses of
facetofont-lock-face, including here. This may have fixed a larger font-lock compatibility issue, but it disabled font-locking of stack frame detail: thefaceset here overrides those uses offont-lock-face.The text was updated successfully, but these errors were encountered: