Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

track-state: Include cljs.core ns info #791

Merged
merged 1 commit into from
Jul 31, 2023
Merged

track-state: Include cljs.core ns info #791

merged 1 commit into from
Jul 31, 2023

Conversation

vemv
Copy link
Member

@vemv vemv commented Jul 30, 2023

Part of clojure-emacs/cider#3385

Cheers - V

@vemv vemv requested a review from bbatsov July 30, 2023 15:35
@@ -219,7 +219,7 @@
(cond
(and cljs (not (contains? old-ns-map 'cljs.core)))
(assoc project-ns-map 'cljs.core
(ns-as-map (cljs-ana/find-ns cljs "cljs.core")
(ns-as-map (cljs-ana/find-ns cljs 'cljs.core)
Copy link
Member Author

@vemv vemv Jul 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All keys in the underlying map are symbols (I verified so locally for clj and cljs).

https://github.com/clojure-emacs/orchard/blob/b992e022caf51e561800a6e07eb9b59b40ee5cbe/src/orchard/cljs/analysis.cljc#L23-L25

Copy link
Member

@bbatsov bbatsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I wonder why no one had noticed this.

@vemv vemv merged commit 9d9cf0c into master Jul 31, 2023
@vemv vemv deleted the 3385 branch July 31, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants