middleware.test: offer fail-fast functionality
#783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Jul 21, 2023
| @@ -971,6 +971,7 @@ Optional parameters:: | |||
|
|
|||
| Returns:: | |||
| * `:elapsed-time` a report of the elapsed time spent running all the given namespaces. The structure is ``:elapsed-time {:ms <integer> :humanized <string>}``. | |||
| * `:fail-fast` If true, the tests will be considered complete after the first test has failed or errored. | |||
There was a problem hiding this comment.
Just keep in mind there's no boolean type in bencode, so true is probably not the best way to describe this. But I get the idea. :-)
There was a problem hiding this comment.
Maybe a small change like When true or the string "true"...
|
Looks good to me overall. |
|
Yeah booleans are a refactor-nrepl custom, wasn't sure if there was anything like that here. Simpler to just expect |
|
Potentially with other transports (e.g. EDN) one can have real booleans, but so far I think we always used the string "true". I was too lazy to check the rest of the codebase. Anyways, no particularly important right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #709
Introduces fail-fast via a
"fail-fast"msg param. The default is to not fail-fast, since I cannot guess the desired behavior for all cider-nrepl clients.For cider-test.el however, I intend to
(defcustom cider-test-fail-fast t).Cheers - V