Support custom print-methods in test reports #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Nov 22, 2020
src/cider/nrepl/middleware/test.clj
Outdated
| @@ -72,7 +76,7 @@ | |||
| c (when (seq test/*testing-contexts*) (test/testing-contexts-str)) | |||
| i (count (get-in (@current-report :results) [ns (:name (meta v))])) | |||
| gen-input (:gen-input @current-report) | |||
| pprint-str #(with-out-str (pp/pprint %))] | |||
| pprint-str #(with-out-str (if (custom-print-method? %) (pp/pprint %) (println %)))] | |||
There was a problem hiding this comment.
Might also be a good idea to add some comment explaining the need for this, and ideally a unit test.
There was a problem hiding this comment.
@bbatsov done! can you check again?
|
Don't forget to add a changelog entry for this bug-fix. |
|
Looks good. Thanks! |
temochka
added a commit
to temochka/cider-nrepl
that referenced
this pull request
Sep 17, 2021
The changes introduced in clojure-emacs#683 resulted in test results always being printed via println instead of clojure.pprint/pprint. BetterThanTomorrow/calva#1280 describes the degraded user experience caused by this issue.
temochka
added a commit
to temochka/cider-nrepl
that referenced
this pull request
Sep 17, 2021
The changes introduced in clojure-emacs#683 resulted in test results always being printed via println instead of clojure.pprint/pprint. BetterThanTomorrow/calva#1280 describes the degraded user experience caused by this issue.
temochka
added a commit
to temochka/cider-nrepl
that referenced
this pull request
Oct 20, 2021
The changes introduced in clojure-emacs#683 resulted in test results always being printed via println instead of clojure.pprint/pprint. BetterThanTomorrow/calva#1280 describes the degraded user experience caused by this issue. This PR limits println usage to matchers-combinators results.
temochka
added a commit
to temochka/cider-nrepl
that referenced
this pull request
Oct 20, 2021
The changes introduced in clojure-emacs#683 resulted in test results always being printed via println instead of clojure.pprint/pprint. BetterThanTomorrow/calva#1280 describes the degraded user experience caused by this issue. This PR limits println usage to matchers-combinators results.
bbatsov
pushed a commit
that referenced
this pull request
Oct 21, 2021
The changes introduced in #683 resulted in test results always being printed via println instead of clojure.pprint/pprint. BetterThanTomorrow/calva#1280 describes the degraded user experience caused by this issue. This PR limits println usage to matchers-combinators results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes test reporting for libraries that rely on custom print logic that can be added by
(defmethod print-method ,,,, such asmatcher-combinators: clojure-emacs/cider#2901 (comment)