dynamic cljs completions with suitable

[rksm]

Before submitting a PR make sure the following things have been done:

• The commits are consistent with our contribution guidelines
• You've added tests to cover your change(s)
• All tests are passing
• The new code is not generating reflection warnings
• You've updated the README (if adding/changing middleware)

Keep in mind that new cider-nrepl builds are automatically deployed to Clojars
once a PR is merged, but only if the CI build is green.

If you're just starting out to hack on cider-nrepl you might find
this article and the
"Design" section of the README extremely useful.

Thanks!

[bbatsov]

Why does suitable need the entire msg? I'm asking mostly because it seems to me that all the other params should be enough to get candidates.

[rksm]

It needs access to the cljs options + repl env + compiler env. We can pull those out and just pass them along but it seemed simpler to hand in the msg.

[bbatsov]

Got it. As this is something minor I guess there's no need to fret over it too much.

[bbatsov]

We should also mention this in the changelog, as it's certainly a noteworthy change.

[arichiardi]

This patch looks great!

I would use another name though for the namespace. cljs-complete is/will be already included in compliment and suitable will be providing js-objects completions only.

I see one day all the functionalities being merged in compliment tbh...

[rksm]

I would use another name though for the namespace. cljs-complete is/will be already included in compliment and suitable will be providing js-objects completions only.

What exactly do you mean? suitable/complete-for-nrepl? Or the cljs-complete function name?

[bbatsov]

I guess he meant the cljs-complete, as we also have this as an ns alias right now. Maybe there's also such a function in compliment now, but I don't think we need to change the name as the prefix will be enough to tell them apart. Plus, we can always change this down the road.

[arichiardi]

Well yes you are right, I can actually change it with my integration PR or something

[arichiardi]

I meant the function name but no probs, it can be tuned later on.