Add a option for filtering vars to the ns-vars middleware

[liquidz]

Fix #566.

[bbatsov]

We can also use var-query here directly. That would simplify a bit the code.

[liquidz]

Thank you for reviewing!
I missed var-query API. I'll fix.

[liquidz]

@bbatsov Fixed!

If we have orchard.query/vars for clojurescript, I think it seems better to use var-query API like test-var-query op.

[bbatsov]

We don't have it yet (something that @arichiardi can probably tackle), but I think we can still adopt the same API and just "fake" it on the cljs side for now (by ignoring everything but the private filter).

[liquidz]

@bbatsov OK! I fixed to take var-query option for filtering vars.
On the cljs side, it only support private? query currently.

[bbatsov]

The PR looks good overall. I mostly wonder if we should try to use here the var-query API, as this would give more flexibility to the ns filtering in general.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@1016f61). Click here to learn what that means.
The diff coverage is 95.12%.

@@           Coverage Diff            @@
##             master    #605   +/-   ##
========================================
  Coverage          ?   76.5%           
========================================
  Files             ?      37           
  Lines             ?    2409           
  Branches          ?     128           
========================================
  Hits              ?    1843           
  Misses            ?     438           
  Partials          ?     128

Impacted Files	Coverage Δ
src/cider/nrepl.clj	95.97% <100%> (ø)
src/cider/nrepl/middleware/ns.clj	90.9% <94.59%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1016f61...0431a95. Read the comment docs.

[bbatsov]

Fantastic work! Thanks! 🙇

[arichiardi]

A newbie question on this, what is the difference between this ns-vars middleware and the information returned by orchard/info?

The kind of seem redundant but maybe ns-vars does something different?

[bbatsov]

I was referring to https://github.com/clojure-emacs/orchard/blob/master/src/orchard/query.clj How is info related to ns-vars?

[arichiardi]

Oh ok it is a different use case...I was just wondering if info can provide the same kind of information there. I did not even know we had such a feature 😄 Sorry for the noise here 😄