-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CircleCI for Continuous Integration #602
Conversation
This patch removes the Travis yaml and adds the CircleCI one instead.
I am building my master branch including this commit here: https://circleci.com/gh/arichiardi/workflows/cider-nrepl/tree/master |
Thanks for tackling this! I've provided a bit of feedback to @shen-tian for the Piggieback setup, and I guess it applies here as well. I also have to familiarize a bit myself with workflows, as some of my feedback might be just promoted by the fact certain things look/feel weird to me. |
Maybe it's best that we get one project right first? We can do nprel or piggieback. Then we can deal with the particular needs of each project. |
Yeah, I agree. I like as a reference the setup outlined here https://github.com/clojure-emacs/cider/blob/master/.circleci/config.yml I think we should probably do nREPL first and take it from there. |
@arichiardi : we got nrepl + piggieback done. So got a template there. Looking at the config here, it's all very similar. Main gotacha is the smoketest stuff: @plexus had a go at this a while back afaik, but it looks like a lot of the testing setup has changed since then. Might still be relevant |
Ok cool I will adjust |
@arichiardi : you wanna finish this PR? Otherwise I can wrap it up. |
@shen-tian if you have a bit of time I don't mind you finishing this, let me add you as collaborator of my fork 😄 |
Any updates here? |
Let me have a quick go at this now.. |
Merge once all ✅ and you are happy. |
Looks good! Great work! 🙇 |
This really is NOT my work but @shen-tian's 😄
Just applying it here.