Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CircleCI for Continuous Integration #602

Merged
merged 5 commits into from
Mar 28, 2019

Conversation

arichiardi
Copy link
Contributor

@arichiardi arichiardi commented Mar 1, 2019

This really is NOT my work but @shen-tian's 😄

Just applying it here.

This patch removes the Travis yaml and adds the CircleCI one instead.
@arichiardi
Copy link
Contributor Author

arichiardi commented Mar 1, 2019

I am building my master branch including this commit here: https://circleci.com/gh/arichiardi/workflows/cider-nrepl/tree/master

@bbatsov
Copy link
Member

bbatsov commented Mar 9, 2019

Thanks for tackling this! I've provided a bit of feedback to @shen-tian for the Piggieback setup, and I guess it applies here as well. I also have to familiarize a bit myself with workflows, as some of my feedback might be just promoted by the fact certain things look/feel weird to me.

@shen-tian
Copy link

Maybe it's best that we get one project right first? We can do nprel or piggieback. Then we can deal with the particular needs of each project.

@bbatsov
Copy link
Member

bbatsov commented Mar 10, 2019

Yeah, I agree. I like as a reference the setup outlined here https://github.com/clojure-emacs/cider/blob/master/.circleci/config.yml I think we should probably do nREPL first and take it from there.

@shen-tian shen-tian mentioned this pull request Mar 11, 2019
@shen-tian
Copy link

shen-tian commented Mar 12, 2019

@arichiardi : we got nrepl + piggieback done. So got a template there. Looking at the config here, it's all very similar. Main gotacha is the smoketest stuff: make test smoketest instead of just make test

@plexus had a go at this a while back afaik, but it looks like a lot of the testing setup has changed since then. Might still be relevant

@arichiardi
Copy link
Contributor Author

arichiardi commented Mar 12, 2019

Ok cool I will adjust the one in orchard this one

@shen-tian
Copy link

@arichiardi : you wanna finish this PR? Otherwise I can wrap it up.

@arichiardi
Copy link
Contributor Author

arichiardi commented Mar 21, 2019

@shen-tian if you have a bit of time I don't mind you finishing this, let me add you as collaborator of my fork 😄

@bbatsov
Copy link
Member

bbatsov commented Mar 28, 2019

Any updates here?

@shen-tian
Copy link

Let me have a quick go at this now..

@shen-tian
Copy link

Merge once all ✅ and you are happy.

@bbatsov bbatsov merged commit 1016f61 into clojure-emacs:master Mar 28, 2019
@bbatsov
Copy link
Member

bbatsov commented Mar 28, 2019

Looks good! Great work! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants