Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for cemerick/piggieback and fall back to cider/piggieback #535

Merged
merged 1 commit into from
Jul 10, 2018

Conversation

dpsutton
Copy link
Contributor

@dpsutton dpsutton commented Jul 1, 2018

CIDER injects cider/piggieback automatically now while some users are
still on cemerick/piggieback. The result is that this will always
return true since cider/piggieback is on the classpath.

Notably, shadow-cljs fakes a cemerick/piggieback and places the
compiler environment there for cider-nrepl. But we see the injected
cider/piggieback and so look for the cljs compiler environment there
rather than in cemerick.

see clojure-emacs/cider#2305

CIDER injects cider/piggieback automatically now while some users are
still on cemerick/piggieback. The result is that this will always
return true since cider/piggieback is on the classpath.

Notably, shadow-cljs fakes a cemerick/piggieback and places the
compiler environment there for cider-nrepl. But we see the injected
cider/piggieback and so look for the cljs compiler environment there
rather than in cemerick.
@bbatsov bbatsov merged commit f737eb6 into clojure-emacs:master Jul 10, 2018
@bbatsov
Copy link
Member

bbatsov commented Jul 10, 2018

I'll merge this, but @thheller should change it soon, as once I switch the middlewares to target the new nREPL server cemerick/piggieback will no longer work at all, and leaving this check would make things confusing, as no one would imagine it's here for shadow-cljs's sake.

@thheller
Copy link

Sorry about that. Totally forgot about this. Just pushed shadow-cljs@2.4.19 which should properly support both or either namespace.

@bbatsov
Copy link
Member

bbatsov commented Jul 10, 2018

Thanks for tackling this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants