Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new C# index syntax #2078

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

RReverser
Copy link
Member

@RReverser RReverser commented Dec 24, 2024

  • Changes index declarations to subclassing+namespacing as [Index.BTree] to better convey that you can't have multiple properties on the same index (e.g. when we add Hash, you can't do [Index(BTree = ..., Hash = ...)].
  • Adds support for inline [Index.BTree] attributes on fields.
  • Adds various diagnostics for invalid index declarations.

Marking as WIP because the proposal that specifies this syntax is in review for now - https://github.com/clockworklabs/SpacetimeDBPrivate/pull/1225 - and the syntax might still change.

Fixes #2048.

Description of Changes

Please describe your change, mention any related tickets, and so on here.

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

Expected complexity level and risk

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Write a test you've completed here.
  • Write a test you want a reviewer to do here, so they can check it off when they're satisfied.

- Changes index declarations to subclassing+namespacing as `[Index.BTree]` to better convey that you can't have multiple properties on the same index (e.g. when we add `Hash`, you can't do `[Index(BTree = ..., Hash = ...)]`.
- Adds support for inline `[Index.BTree]` attributes on fields.
- Adds various diagnostics for invalid index declarations.

Marking as WIP because the proposal that specifies this syntax is in review for now - clockworklabs/SpacetimeDBPrivate#1225 - and the syntax might still change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C# index attribute syntax doesn't match Rust
1 participant