Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strategy to use the Portable Contacts format #6

Merged
merged 1 commit into from
Sep 1, 2016

Conversation

DJphilomath
Copy link
Contributor

For the strategy to be compatible with other libraries using passport, the profile has to comply with the Portable Contact format.
It is referenced in http://passportjs.org/docs/profile

You can read a draft of the spec in
http://hdknr.github.io/docs/identity/poco.html

I changed the profile parser to change from the Microsoft format to the PoCo format. In the strategy, the profile parser is called (it was not called).

I stumbled with this bug while trying to use this passport integration with the loopback-passport-component. With this change the profile can be consumed without any problem.

@clocked0ne
Copy link
Owner

Excellent, I should have done this before publishing but forgot to come back to it, so this is much appreciated. I will publish as 2.0.0 shortly since this is a breaking change for anyone using the current profile response.

@clocked0ne clocked0ne merged commit b1326ed into clocked0ne:master Sep 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants