Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw if compilation failed #39

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Conversation

tonsky
Copy link
Contributor

@tonsky tonsky commented Nov 9, 2024

It would be great to have a way to know if compilation was successful

@alexander-yakushev
Copy link
Collaborator

alexander-yakushev commented Nov 10, 2024

I don't object to this change (I even have a [probably false] memory of it working like that back when I used Virgil with Boot, but source doesn't confirm it), but I wonder what's your workflow. I always invoke virgil/compile-java from the REPL buffer, so I immediately see the compilation errors in stderr. Do you evaluate it in the code buffer?

@tonsky
Copy link
Contributor Author

tonsky commented Nov 11, 2024 via email

@alexander-yakushev alexander-yakushev merged commit aad99ac into clj-commons:master Nov 11, 2024
@alexander-yakushev
Copy link
Collaborator

Thank you! Published in 0.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants