Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pools] Allow adjustment by 1 #34

Merged
merged 1 commit into from
Nov 27, 2023
Merged

[pools] Allow adjustment by 1 #34

merged 1 commit into from
Nov 27, 2023

Conversation

arnaudgeiser
Copy link
Collaborator

I assume this is not intentional – pool will not adjust upwards if the adjustment value for a key is exactly 1. Not critical, but slightly annoying.

Co-authored-by: alexander-yakushev alex@bytopia.org

@arnaudgeiser
Copy link
Collaborator Author

Sorry @alexander-yakushev, I accidentally closed your PR...

@alexander-yakushev
Copy link
Collaborator

No problem :)

@KingMob
Copy link
Collaborator

KingMob commented Nov 27, 2023

Dirigiste should probably copy one of the circleci.yml files so it automatically runs tests...

@alexander-yakushev
Copy link
Collaborator

Will do.

Copy link
Collaborator

@KingMob KingMob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudgeiser
Copy link
Collaborator Author

Merging this PR, to me the circle.ci adjustment is orthogonal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants