-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Message added on visualize error on forceful termination #381
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fails on windows due to no shell
. Can you adjust the test to use process.exit
instead?
Sure! Done! |
@Ceres6 this keeps failing |
Sorry, file name mismatch 🤦🏻 |
It seems node 14 handles differently creating a read stream from an unexisting file than 16/18 and therefore no error is brought up and the new test fails. |
You can skip v14 in the tests |
Should I skip v14 only for that test or in general? |
For this test. The v14 support will be only dropped when v14 becomes end-of-life. |
I'm not being able to skip the test, I was trying with the |
@Ceres6 https://node-tap.org/docs/api/#ttestname-options-function. see skip option |
Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com>
@Ceres6 I realize you're now busy on something else but it would be good to get this out the door. |
I will try to find some time in this week to see if I can fix it. |
Just to be aware. I'm testing with node 18.10 (instead of 18.13) and there are a lot less failing tests. Maybe something has changed in the latest version and now it is receiving SIGABRT instead of logging the output |
Rebased, I have seen the issue, it's what I thought. Let me know if I can help with that in any way. |
Closes #333