Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message added on visualize error on forceful termination #381

Merged
merged 11 commits into from
Feb 22, 2023

Conversation

Ceres6
Copy link
Contributor

@Ceres6 Ceres6 commented Jan 12, 2023

Closes #333

Copy link
Contributor

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simoneb simoneb requested a review from RafaelGSS January 12, 2023 12:06
Copy link
Contributor

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails on windows due to no shell. Can you adjust the test to use process.exit instead?

@Ceres6
Copy link
Contributor Author

Ceres6 commented Jan 12, 2023

Sure! Done!

@Ceres6 Ceres6 requested a review from RafaelGSS January 12, 2023 16:44
@RafaelGSS
Copy link
Contributor

@Ceres6 this keeps failing

@Ceres6
Copy link
Contributor Author

Ceres6 commented Jan 12, 2023

Sorry, file name mismatch 🤦🏻

@Ceres6
Copy link
Contributor Author

Ceres6 commented Jan 13, 2023

It seems node 14 handles differently creating a read stream from an unexisting file than 16/18 and therefore no error is brought up and the new test fails.
For the failing node 18 tests in Windows and Ubuntu they are not the new one and don't seem to be related with the changes I made so I'm not sure about what we should do here @RafaelGSS

@RafaelGSS
Copy link
Contributor

You can skip v14 in the tests

@Ceres6
Copy link
Contributor Author

Ceres6 commented Jan 13, 2023

Should I skip v14 only for that test or in general?

@RafaelGSS
Copy link
Contributor

Should I skip v14 only for that test or in general?

For this test. The v14 support will be only dropped when v14 becomes end-of-life.

@Ceres6
Copy link
Contributor Author

Ceres6 commented Jan 17, 2023

I'm not being able to skip the test, I was trying with the --grep option of tap but it keeps running all the test no matter what I pass. Any ideas?

@simoneb
Copy link
Contributor

simoneb commented Jan 17, 2023

bin.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Ceres6 and others added 2 commits January 19, 2023 12:42
Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com>
@Ceres6 Ceres6 requested a review from RafaelGSS January 19, 2023 11:55
@simoneb
Copy link
Contributor

simoneb commented Feb 16, 2023

@Ceres6 I realize you're now busy on something else but it would be good to get this out the door.

@Ceres6
Copy link
Contributor Author

Ceres6 commented Feb 16, 2023

I will try to find some time in this week to see if I can fix it.

@Ceres6
Copy link
Contributor Author

Ceres6 commented Feb 16, 2023

Just to be aware. I'm testing with node 18.10 (instead of 18.13) and there are a lot less failing tests. Maybe something has changed in the latest version and now it is receiving SIGABRT instead of logging the output

@RafaelGSS
Copy link
Contributor

@Ceres6 can you rebase on main? See also #393

@Ceres6
Copy link
Contributor Author

Ceres6 commented Feb 20, 2023

Rebased, I have seen the issue, it's what I thought. Let me know if I can help with that in any way.

@RafaelGSS RafaelGSS merged commit c4aacba into clinicjs:main Feb 22, 2023
@github-actions github-actions bot mentioned this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Analysing dataError: ENOENT: no such file or directory [...]<pid>.clinic-doctor-processstat
3 participants