Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use child process PID instead of parent PID for default name, and resolve issues with custom name and output destination #148

Conversation

rubenpad
Copy link
Contributor

@rubenpad rubenpad commented Jun 21, 2023

…d resolve issues with custom name and output destination
README.md Outdated Show resolved Hide resolved
@RafaelGSS
Copy link
Contributor

FYI we need to make this change in other tools (flame, bubbleprof and doctor) to enable it via clinic [TOOL]

@RafaelGSS RafaelGSS merged commit ba66145 into clinicjs:main Jun 22, 2023
@rubenpad
Copy link
Contributor Author

FYI we need to make this change in other tools (flame, bubbleprof and doctor) to enable it via clinic [TOOL]

I think this already works in the other tools. I have executed the following commands using the latest version of clinic and they work well:

  • clinic [TOOL] --dest my-custom-dest -- node my-script.js
  • clinic [TOOL] --name my-custom-name -- node my-script.js
  • clinic [TOOL] --dest my-custom-dest --name my-custom-name -- node my-script.js

@RafaelGSS
Copy link
Contributor

RafaelGSS commented Jun 22, 2023

Great, I forgot I did it already. I'll release two new versions of Clinic.js tomorrow (including your fix) and one major dropping v14 support.

@rubenpad rubenpad deleted the fix/use-the-child-process-pid-instead-of-parent-pid branch June 22, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants