Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gsd/develop: add capability to call radiation on physics timestep for first N time steps #3

Conversation

climbfuji
Copy link
Owner

@climbfuji climbfuji commented Dec 6, 2019

This PR adds the capability to allow for radiation being called on physics timestep for first nhfrad timesteps (coldstarts only, for spinup) to physics/GFS_time_vary_pre.fv3.*

The new functionality is activated by setting nhfrad in the gfs physics namelist section to a value larger than one (default is zero).

Associated PR: climbfuji/fv3atm#1

This PR has been tested to work on macOS/GNU and needs to be tested for b4b identical results when nhfrad is not set (default value is zero) on hera/intel.

@climbfuji
Copy link
Owner Author

@grantfirl should this change be made for SCM as well, or does radiation run on the physics time step anyway?

@grantfirl
Copy link

@grantfirl should this change be made for SCM as well, or does radiation run on the physics time step anyway?

Calls to radiation for the SCM are controlled identically to FV3, by the namelist values of fhswr and fhlwr converted to nsswr and nslwr in control_initialize, then used in GFS_time_vary_pre.scm to set the logicals. So, if it is deemed necessary for FV3, we'll probably want to have it in SCM too.

@climbfuji
Copy link
Owner Author

This has been replaced by NOAA-GSL#1.

@climbfuji climbfuji closed this Dec 12, 2019
climbfuji pushed a commit that referenced this pull request Jun 30, 2020
climbfuji pushed a commit that referenced this pull request Nov 24, 2020
climbfuji pushed a commit that referenced this pull request Feb 11, 2021
climbfuji pushed a commit that referenced this pull request Mar 30, 2021
climbfuji pushed a commit that referenced this pull request Apr 26, 2021
climbfuji pushed a commit that referenced this pull request Aug 5, 2021
Constant branch update from Dom 2021/08/02
climbfuji pushed a commit that referenced this pull request Oct 18, 2021
Update to mraerosol branch from Dom
climbfuji pushed a commit that referenced this pull request Dec 22, 2021
Update cloud_cover_xr with latest change from NCAR ccpp-physics main
climbfuji pushed a commit that referenced this pull request Mar 3, 2022
Fix the rest of the Cheyenne/GNU tests
@climbfuji climbfuji deleted the first_n_radiation_calls_on_physics_timestep_for_spinup branch June 27, 2022 03:12
climbfuji pushed a commit that referenced this pull request Dec 27, 2023
climbfuji pushed a commit that referenced this pull request Dec 27, 2023
Revert combination, update to ufs/dev, and update CODEOWNERS
climbfuji pushed a commit that referenced this pull request Dec 27, 2023
climbfuji pushed a commit that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants