Humidex #33
Merged
Humidex #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
fix typo
|
Sobald du die Tests angepasst und die Mergekonflikte behoben hast, kann ich den PR mergen. |
added correct test results for HIX
for more information, see https://pre-commit.ci
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #33 +/- ##
==========================================
+ Coverage 94.77% 94.79% +0.02%
==========================================
Files 14 14
Lines 1262 1268 +6
==========================================
+ Hits 1196 1202 +6
Misses 66 66
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
i added setup.cfg for convenience
Comment on lines
+4
to
+12
| E203 | ||
| # module level import not at top of file | ||
| E402 | ||
| # line too long - let black worry about that | ||
| E501 | ||
| # do not assign a lambda expression, use a def | ||
| E731 | ||
| # line break before binary operator | ||
| W503 |
There was a problem hiding this comment.
we will ignore these conventions
|
@SusannePfeifer007 check mal pre-commit! Das ist mega nützlich und man muss sich keine Gedanken mehr um Formatierung machen! |
larsbuntemeyer
merged commit bce0df7
into
climate-service-center:master
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitte nimm den auf