Init logic to retry http request if there are connection problem #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
darosior
suggested changes
Aug 30, 2020
| chunk.memory = tal_arr(ctx, u8, 64); | ||
| chunk.size = 0; | ||
|
|
||
| @@ -76,47 +79,78 @@ static size_t write_memory_callback(void *contents, size_t size, size_t nmemb, | |||
|
|
|||
| static u8 *request(const tal_t *ctx, const char *url, const bool post, | |||
| const char *data) { | |||
|
|
|||
| CURL *curl; | ||
| CURLcode res; | ||
| curl = curl_easy_init(); | ||
| if (!curl) { | ||
| plugin_log(cmd->plugin, LOG_UNUSUAL, "Error with lincurl init call"); |
There was a problem hiding this comment.
Suggested change
| plugin_log(cmd->plugin, LOG_UNUSUAL, "Error with lincurl init call"); | |
| plugin_log(cmd->plugin, LOG_BROKEN, "Could not get a curl context"); |
| struct curl_memory_data chunk; | ||
| const struct command *cmd = (struct command*) ctx; |
There was a problem hiding this comment.
Ouch. No, a tal_t struct cannot be cast to a command one!
There was a problem hiding this comment.
Ops! Is i want the log here I could add another parameter to the request? only solution?
Comment on lines
+118
to
+128
| retrycurl: | ||
| res = curl_easy_perform(curl); | ||
|
|
||
| if (res != CURLE_OK) { | ||
| if (time < retry_time){ | ||
| time++; | ||
| plugin_log(cmd->plugin, LOG_DBG, "Curl return a result different to CURLE_OK, it is %d", CURLE_OK); | ||
| sleep(wait_time); | ||
| plugin_log(cmd->plugin, LOG_DBG, "%ld: Retry curl request to URL: %s", time, url); | ||
| goto retrycurl; | ||
| } |
There was a problem hiding this comment.
Hmm. I propose:
for (;;) {
res = curl_easy_perform(curl);
if (res == CURLE_OK)
break;
if (++time > retry_time)
return tal_free(chunk.memory);
sleep(wait_time);
}There was a problem hiding this comment.
Very cool :-) I was too excited to use the goto :-P
Comment on lines
+133
to
+145
| time = 0; | ||
| //FIXME(vincenzopalazzo): Is the idea pass the test, Is good refactoring this code to write it only one times | ||
| //and execut if in different part of code. | ||
| retryinfo: | ||
| curl_easy_getinfo(curl, CURLINFO_RESPONSE_CODE, &response_code); | ||
| if (response_code != 200) { | ||
| if(time < retry_time){ | ||
| time++; | ||
| plugin_log(cmd->plugin, LOG_DBG, "bad code in the info answare! wait %d before retry", wait_time); | ||
| sleep(wait_time); | ||
| plugin_log(cmd->plugin, LOG_DBG, "%ld: Retry info request to URL=%s", time, url); | ||
| goto retryinfo; | ||
| } |
There was a problem hiding this comment.
Just make my above proposition a function ?
|
|
||
| static char *endpoint = NULL; | ||
| static char *cainfo_path = NULL; | ||
| static char *capath = NULL; | ||
| static u64 verbose = 0; | ||
| static int wait_time = 60; //Time express in second |
There was a problem hiding this comment.
This is way too long. I think it can just be a hardcoded value in a make_curl_request function ?
There was a problem hiding this comment.
Do you mean the time is too long?
| return tal_free(chunk.memory); | ||
| } | ||
| curl_easy_cleanup(curl); | ||
| tal_resize(&chunk.memory, chunk.size); | ||
| return chunk.memory; | ||
| } | ||
|
|
||
| static char *request_get(const tal_t *ctx, const char *url) { | ||
| static char *request_get(const tal_t *ctx, const char *url) { |
| @@ -148,7 +182,7 @@ static struct command_result *getchaininfo(struct command *cmd, | |||
| const char *buf UNUSED, | |||
| const jsmntok_t *toks UNUSED) { | |||
| char *err; | |||
|
|
|||
|
Do you mind if i propose an alternate PR ? |
@darosior Absolutly no! I know that my C is very bad at the moment! I can not wait to see you PR :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In this PR I propose the idea described inside this issue #16. In most of cases the connection can have problems, e.g: The VPN connection crashed during a esplora fetch operation, and this cause the crash of lightningd. Or the esplora don't have a feerate available for the last block and with this code, the plugin can wait before to retry the operation.
In this PR I wrote the not maintainable code but I promise that if this logic work I will refactoring it with a call back function :-)
I hope this can help!
Signed-off-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com