Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder of TbInputInline::maskedTextField or TbInputInline::typeAheadField was overwritten by useless code #694

Closed
hightman opened this issue Oct 9, 2013 · 1 comment
Labels
Milestone

Comments

@hightman
Copy link
Contributor

hightman commented Oct 9, 2013

As the title, there are code such as following in src/widgets/input/TbInputInline.php:

    $this->setPlaceholder();
    $this->htmlOptions['placeholder'] = $this->model->getAttributeLabel($this->attribute);

It harshly overwrite the customized placeholder option.

hijarian added a commit that referenced this issue Oct 9, 2013
Fixed issue #694: Fix for placeholder overwriting in TbInputInline
@hijarian
Copy link
Contributor

hijarian commented Oct 9, 2013

Thanks for finding this problem, and especially - for providing a solution.

By the way, you probably will be interested in the upcoming change in TbActiveForm, committed as a PR #687

@hijarian hijarian closed this as completed Oct 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants