Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a commonNav option to set nav html code in one file only #95

Merged
merged 2 commits into from
Apr 20, 2021
Merged

add a commonNav option to set nav html code in one file only #95

merged 2 commits into from
Apr 20, 2021

Conversation

dcaillibaud
Copy link
Contributor

The nav html code is fetched after each page loading (instead of being embedded), in my case total doc weight get reduced from 2.3Go to 40Mo (2Mo for nav.inc.html, 600k html pages).

Close #75

… on each page loading instead of embedding it, in my case total doc weight get reduced from 2.3Go to 40Mo)
@dcaillibaud
Copy link
Contributor Author

Feel free to change the "commonNav" name (it's the only one in camelCase, perhaps not a good idea).

@ar2rsawseen ar2rsawseen merged commit 6b51a64 into clenemt:master Apr 20, 2021
@laramurphyyx
Copy link

This is really helpful! Do you plan to have a release for this soon?

@dcaillibaud
Copy link
Contributor Author

This is really helpful!
Thanks ;-)

Do you plan to have a release for this soon?

It's already released (since at least 1.2.0) => ar2rsawseen merged 2 commits into clenemt:master from dcaillibaud:addCommonNavOption on 20 Apr

Before this merge I put in my package.json
"docdash": "github:dcaillibaud/docdash#addCommonNavOption",
but I rollback to a more usual config with
"docdash": "^1.2.0",
for a while.

@dcaillibaud dcaillibaud deleted the addCommonNavOption branch July 7, 2021 13:50
@laramurphyyx
Copy link

Thanks for getting back to me so quickly!

At the moment, I'm currently consuming docdash ^1.2.0 within my package.json from npm but unfortunately can't see the new features you've included in PR #95. I've looked at the github release - https://github.com/clenemt/docdash/releases/tag/1.2.0 - and it doesn't say this feature is included. It seems the 1.2 version was released on 26/01/2020 but this PR was only merged on 20/04/2021. I assumed that this did not contain the new feature, is this the case?

The github release version 1.2.0 seems to be the same as the public npm version 1.2.0 - https://www.npmjs.com/package/docdash/v/1.2.0 - which also does not include the feature.

I've pulled down docdash master locally and verified the feature works perfectly (great job 👍 ), so I'm just looking for clarification as to the plan for the associated npm release it's planned to be contained in.

Any help would be appreciated, would love to use this feature. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhancement wish] common nav for all html pages
3 participants