refacto some converters useless methods

clementtalleu · Jun 7, 2024 · e19f884 · e19f884
1 parent 8bffe7b
commit e19f884
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 34 deletions.
diff --git a/src/Om/Converters/AbstractDateTimeConverter.php b/src/Om/Converters/AbstractDateTimeConverter.php
@@ -27,5 +27,8 @@ public function supportsConversion(string $type, mixed $data): bool
 
     abstract public function revert($data, string $type): \DateTime;
 
-    abstract public function supportsReversion(string $type, mixed $value): bool;
+    public function supportsReversion(string $type, mixed $value): bool
+    {
+        return $type === 'DateTime' || $type === 'DateTimeInterface';
+    }
 }
diff --git a/src/Om/Converters/AbstractDateTimeImmutableConverter.php b/src/Om/Converters/AbstractDateTimeImmutableConverter.php
@@ -21,5 +21,8 @@ public function supportsConversion(string $type, mixed $data): bool
 
     abstract public function revert($data, string $type): \DateTimeImmutable;
 
-    abstract public function supportsReversion(string $type, mixed $value): bool;
+    public function supportsReversion(string $type, mixed $value): bool
+    {
+        return $type === 'DateTimeImmutable';
+    }
 }
diff --git a/src/Om/Converters/AbstractObjectConverter.php b/src/Om/Converters/AbstractObjectConverter.php
@@ -18,10 +18,7 @@ public function supportsConversion(string $type, mixed $data): bool
 
     abstract public function revert($data, string $type): mixed;
 
-    public function supportsReversion(string $type, mixed $value): bool
-    {
-        return class_exists($type) && !in_array($type, AbstractDateTimeConverter::DATETYPES_NAMES);
-    }
+    abstract public function supportsReversion(string $type, mixed $value): bool;
 
     protected function extractPropertyValue(Property $propertyAttribute, \ReflectionProperty $property, object $data): mixed
     {

diff --git a/src/Om/Converters/HashModel/DateTimeConverter.php b/src/Om/Converters/HashModel/DateTimeConverter.php
@@ -21,13 +21,4 @@ public function revert($data, string $type): \DateTime
 
         return new \DateTime($data);
     }
-
-    public function supportsReversion(string $type, mixed $value): bool
-    {
-        if ($type === 'DateTime' || $type === 'DateTimeInterface') {
-            return true;
-        }
-
-        return false;
-    }
 }
diff --git a/src/Om/Converters/HashModel/DateTimeImmutableConverter.php b/src/Om/Converters/HashModel/DateTimeImmutableConverter.php
@@ -16,13 +16,4 @@ public function revert($data, string $type): \DateTimeImmutable
 
         return new \DateTimeImmutable($data);
     }
-
-    public function supportsReversion(string $type, mixed $value): bool
-    {
-        if ($type === 'DateTimeImmutable') {
-            return true;
-        }
-
-        return false;
-    }
 }
diff --git a/src/Om/Converters/JsonModel/DateTimeConverter.php b/src/Om/Converters/JsonModel/DateTimeConverter.php
@@ -23,9 +23,4 @@ public function revert($data, string $type): \DateTime
     {
         return new \DateTime($data['date'], new \DateTimeZone($data['timezone']));
     }
-
-    public function supportsReversion(string $type, mixed $value): bool
-    {
-        return $type === 'DateTime' || $type === 'DateTimeInterface';
-    }
 }
diff --git a/src/Om/Converters/JsonModel/DateTimeImmutableConverter.php b/src/Om/Converters/JsonModel/DateTimeImmutableConverter.php
@@ -23,9 +23,4 @@ public function revert($data, string $type): \DateTimeImmutable
     {
         return new \DateTimeImmutable($data['date'], new \DateTimeZone($data['timezone']));
     }
-
-    public function supportsReversion(string $type, mixed $value): bool
-    {
-        return $type === 'DateTimeImmutable';
-    }
 }