Merge pull request cms-sw#15 from clelange/PR18236_Followup

fix magic numbers, remove superfluous include
clelange · Apr 18, 2017 · 38018c2 · 38018c2
2 parents c881803 + 45e3da7
commit 38018c2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/RecoLocalCalo/HGCalRecAlgos/interface/HGCalImagingAlgo.h b/RecoLocalCalo/HGCalRecAlgos/interface/HGCalImagingAlgo.h
@@ -296,7 +296,7 @@ inline double distance(const Hexel &pt1, const Hexel &pt2) {   //2-d distance on
 }
 double calculateLocalDensity(std::vector<KDNode> &, KDTree &, const unsigned int);   //return max density
 double calculateDistanceToHigher(std::vector<KDNode> &, KDTree &);
-int findAndAssignClusters(std::vector<KDNode> &, KDTree &, double, KDTreeBox &, const int);
+int findAndAssignClusters(std::vector<KDNode> &, KDTree &, double, KDTreeBox &, const unsigned int);
 math::XYZPoint calculatePosition(std::vector<KDNode> &);
 
 // attempt to find subclusters within a given set of hexels

diff --git a/RecoLocalCalo/HGCalRecAlgos/src/HGCalImagingAlgo.cc b/RecoLocalCalo/HGCalRecAlgos/src/HGCalImagingAlgo.cc
@@ -248,16 +248,16 @@ double HGCalImagingAlgo::calculateDistanceToHigher(std::vector<KDNode> &nd, KDTr
   return maxdensity;
 }
 
-int HGCalImagingAlgo::findAndAssignClusters(std::vector<KDNode> &nd,KDTree &lp, double maxdensity, KDTreeBox &bounds, const int layer){
+int HGCalImagingAlgo::findAndAssignClusters(std::vector<KDNode> &nd,KDTree &lp, double maxdensity, KDTreeBox &bounds, const unsigned int layer){
 
   //this is called once per layer...
   //so when filling the cluster temporary vector of Hexels we resize each time by the number
   //of clusters found. This is always equal to the number of cluster centers...
 
   unsigned int clusterIndex = 0;
   float delta_c = 9999.;
-  if( layer<=28 ) delta_c = vecDeltas[0];
-  else if( layer<=40 ) delta_c = vecDeltas[1];
+  if( layer<=lastLayerEE ) delta_c = vecDeltas[0];
+  else if( layer<=lastLayerFH ) delta_c = vecDeltas[1];
   else delta_c = vecDeltas[2];
 
   std::vector<size_t> rs = sorted_indices(nd); // indices sorted by decreasing rho

diff --git a/RecoLocalCalo/HGCalRecProducers/plugins/HGCalClusterTestProducer.cc b/RecoLocalCalo/HGCalRecProducers/plugins/HGCalClusterTestProducer.cc
@@ -18,7 +18,6 @@
 
 #include <memory>
 #include <chrono>
-#include <iostream>
 
 #include "RecoLocalCalo/HGCalRecAlgos/interface/HGCalImagingAlgo.h"
 #include "RecoLocalCalo/HGCalRecAlgos/interface/HGCalDepthPreClusterer.h"