changed np.bool deprecated in numpy 1.20.0, changed to bool #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkhenning
reviewed
Mar 29, 2023
| @@ -252,7 +252,7 @@ class TritonPreprocessRequest(BasePreprocessRequest): | |||
| np.uint64: 'uint64_contents', | |||
| np.int32: 'int_contents', | |||
| np.uint: 'uint_contents', | |||
| np.bool: 'bool_contents', | |||
| bool: 'bool_contents', | |||
There was a problem hiding this comment.
For backwards compatibility, can you please change bool to getattr(np, 'bool', bool)? 🙏
|
@anon-it, can you please address the comments? |
|
Closing this as the fix has already been introduced. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this commit a04d1bd.
np.boolwas a deprecated alias for the builtinbool. To avoid this error in existing code, useboolby itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, usenp.bool_here.The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at:
https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations