Support component search by provider #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for blissful-goodall-fa23f6 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@disulliv @mpcen ready for review For additional notes on search api behaviour, see clearlydefined/service#942. |
qtomlinson
added a commit
to qtomlinson/website
that referenced
this pull request
Jul 11, 2022
1. Added provider to the pattern string for coordinates suggestion The search api call in service ignores provider type. For example, the following call return results contains co-ordinates with provider other than npmjs: curl -X GET "https://dev-api.clearlydefined.io/definitions?pattern=jw&type=npm" -H "accept: */*" This is probably by design: the suggestion api only takes the pattern string into account. When provider is included in the pattern string, the search result reflects the provider specification. The solution is to pass the provider information when searching in PageBrowse. 2. Also trigger search when provider is changed Task: clearlydefined#990
qtomlinson
force-pushed
the
qt/search_with_provider
branch
2 times, most recently
from
7ca72e8 to
84e6371
Compare
disulliv
approved these changes
Aug 3, 2022
|
@disulliv On the UI, searching for components is always within a certain provider. It is initially set to be npm, at PageBrowse (line 37). |
|
Can we hold off merging this until searching is fixed. I'm current looking at the search issues |
1. Added provider to the pattern string for coordinates suggestion The search api call in service ignores provider type. For example, the following call returns co-ordinates with provider other than npmjs: curl -X GET "https://dev-api.clearlydefined.io/definitions?pattern=jw&type=npm" -H "accept: */*" This is probably by design: the suggestion api only takes the pattern string into account. When provider is included in the pattern string, the search result reflects the provider specification. The solution is to pass the provider information when searching in PageBrowse. 2. Also trigger search when provider is changed Task: clearlydefined#957
qtomlinson
force-pushed
the
qt/search_with_provider
branch
from
84e6371 to
bf4736d
Compare
mpcen
reviewed
Sep 27, 2022
|
Address feedback in #1000 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search api call in service ignores provider type.
For example, the following call return co-ordinates with provider other than npmjs:
curl -X GET "https://dev-api.clearlydefined.io/definitions?pattern=jw&type=npm" -H "accept: /"
This is probably by design: the suggestion api only takes the pattern
string into account.
When provider is included in the pattern string, the search result
reflects the provider specification. The solution is to pass the
provider information when searching in PageBrowse.
Task: #957