Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle NotFound when mapping pypi coordinates #1016

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Handle NotFound when mapping pypi coordinates #1016

merged 2 commits into from
Jan 10, 2024

Conversation

qtomlinson
Copy link
Collaborator

@qtomlinson qtomlinson commented Nov 8, 2023 •
edited
Loading

Task: #957

@qtomlinson qtomlinson marked this pull request as ready for review November 8, 2023 23:00
@qtomlinson
Copy link
Collaborator Author

@jeffwilcox @JamieMagee for review

@qtomlinson qtomlinson requested a review from elrayle January 3, 2024 23:25
elrayle
elrayle approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@elrayle elrayle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for handling the 404 condition and updating the tests to make them more readable.

@qtomlinson qtomlinson merged commit 4ae722e into clearlydefined:master Jan 10, 2024
2 checks passed
@qtomlinson qtomlinson deleted the qt/fix-pypi-404 branch February 7, 2024 03:13
@lumaxis lumaxis mentioned this pull request Feb 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elrayle elrayle elrayle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qtomlinson @elrayle