Renaming

clearlydefined · Nov 20, 2024 · c541259 · c541259
1 parent a83fe72
commit c541259
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 16 deletions.
diff --git a/providers/stores/azblobHarvestStore.js b/providers/stores/azblobHarvestStore.js
@@ -50,11 +50,11 @@ class AzHarvestBlobStore extends AbstractAzBlobStore {
     // Note that here we are assuming the number of blobs will be small-ish (<10) and
     // a) all fit in memory reasonably, and
     // b) fit in one list call (i.e., <5000)
-    const files = await this._getAllFiles(coordinates)
-    return await this._getContent(files)
+    const allFilesList = await this._getListOfAllFiles(coordinates)
+    return await this._getContent(allFilesList)
   }
 
-  _getAllFiles(coordinates) {
+  _getListOfAllFiles(coordinates) {
     const name = this._toStoragePathFromCoordinates(coordinates)
     return new Promise((resolve, reject) =>
       this.blobService.listBlobsSegmentedWithPrefix(this.containerName, name, null, resultOrError(resolve, reject))
@@ -100,12 +100,12 @@ class AzHarvestBlobStore extends AbstractAzBlobStore {
    *
    */
   async getAllLatest(coordinates) {
-    const allFiles = await this._getAllFiles(coordinates)
-    const latestFiles = this._getLatestFiles(allFiles)
-    return await this._getContent(latestFiles)
+    const allFilesList = await this._getListOfAllFiles(coordinates)
+    const latestFilesList = this._getListOfLatestFiles(allFilesList)
+    return await this._getContent(latestFilesList)
   }
 
-  _getLatestFiles(allFiles) {
+  _getListOfLatestFiles(allFiles) {
     let latestFiles = []
     const names = allFiles.map(file => file.name)
     try {

diff --git a/providers/stores/fileHarvestStore.js b/providers/stores/fileHarvestStore.js
@@ -50,11 +50,11 @@ class FileHarvestStore extends AbstractFileStore {
     // Note that here we are assuming the number of blobs will be small-ish (<10) and
     // a) all fit in memory reasonably, and
     // b) fit in one list call (i.e., <5000)
-    const files = await this._getAllFiles(coordinates)
-    return await this._getContent(files)
+    const allFilesList = await this._getListOfAllFiles(coordinates)
+    return await this._getContent(allFilesList)
   }
 
-  async _getAllFiles(coordinates) {
+  async _getListOfAllFiles(coordinates) {
     const root = this._toStoragePathFromCoordinates(coordinates)
     try {
       return await recursive(root, ['.DS_Store'])
@@ -90,12 +90,12 @@ class FileHarvestStore extends AbstractFileStore {
    *
    */
   async getAllLatest(coordinates) {
-    const allFiles = await this._getAllFiles(coordinates)
-    const latestFiles = this._getLatestFiles(allFiles)
-    return await this._getContent(latestFiles)
+    const allFilesList = await this._getListOfAllFiles(coordinates)
+    const latestFilesList = this._getListOfLatestFiles(allFilesList)
+    return await this._getContent(latestFilesList)
   }
 
-  _getLatestFiles(allFiles) {
+  _getListOfLatestFiles(allFiles) {
     let latestFiles = []
     try {
       const latest = this._getLatestToolVersions(allFiles)

diff --git a/test/providers/store/fileHarvest.js b/test/providers/store/fileHarvest.js
@@ -131,7 +131,7 @@ describe('getAll and getAllLatest', () => {
   })
 
   it('should get latest files', () => {
-    const result = fileStore._getLatestFiles(allFiles)
+    const result = fileStore._getListOfLatestFiles(allFiles)
     expect(result.length).to.eq(4)
     expect(Array.from(result)).to.equalInAnyOrder([
       '/tmp/harvested_data/pypi/pypi/-/platformdirs/revision/4.2.0/tool/clearlydefined/1.4.1.json',
@@ -144,7 +144,7 @@ describe('getAll and getAllLatest', () => {
   it('should handle error', () => {
     fileStore._getLatestToolVersions = sinon.stub().throws(new Error('test error'))
     fileStore.logger.error = sinon.stub()
-    const result = fileStore._getLatestFiles(allFiles)
+    const result = fileStore._getListOfLatestFiles(allFiles)
     expect(fileStore.logger.error.calledOnce).to.be.true
     expect(result.length).to.eq(allFiles.length)
     expect(Array.from(result)).to.equalInAnyOrder(allFiles)