Exclude .git directory content when calculating package file count #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mpcen ready for review |
qtomlinson
force-pushed
the
qt/exclude-git-dir
branch
from
26df2bf to
6eead81
Compare
|
@jeffwilcox @mpcen rebased and ready for review. |
|
@elrayle ready for review |
|
The existing code only exclude .git directory itself, but not its containing files. This fix intends to exclude .git directory and its contents. |
elrayle
reviewed
Jan 10, 2024
qtomlinson
force-pushed
the
qt/exclude-git-dir
branch
from
ea3c808 to
ca3901a
Compare
lumaxis
reviewed
Feb 28, 2024
elrayle
reviewed
Feb 28, 2024
lumaxis
approved these changes
Mar 18, 2024
| @@ -150,7 +150,7 @@ class AbstractProcessor extends BaseHandler { | |||
| */ | |||
| async filterFiles(location) { | |||
| const fullList = await this.getFiles(location) | |||
| const filteredList = fullList.filter(file => isValidExcludingGit(file)) | |||
| const filteredList = fullList.filter(file => file && !isGitFile(file)) | |||
There was a problem hiding this comment.
We don't necessarily need to check if file is undefined here since isGitFile already does: if (!file) return false
There was a problem hiding this comment.
Hm... I am afraid that the check for undefined file is still necessary. In case of falsy file, isGitFile(file) returns false, and !isGitFile returns true. Using !isGitFile alone would not exclude falsy file values.
qtomlinson
added a commit
to qtomlinson/crawler
that referenced
this pull request
Apr 10, 2024
This is for fix to exclude .git directory content in recent PR (clearlydefined#525). Bump up the version to allow reharvest of pod components.
qtomlinson
added a commit
to qtomlinson/crawler
that referenced
this pull request
Apr 17, 2024
The recent fix to exclude content in the .git directory (clearlydefined#525) from pod packages will cause the file count to be different from the previous version. Update the toolVersion for PodExtract to 2.0.0 to reflect this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discovered during sanity test for upgrading crawler image to use node:18-bullseye. The file count for pod/cocoapods/-/SoftButton/0.1.0 was different:
The content of .git directory should be excluded for the package file count.
Task: #529