Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lowercasing package names for nuget api fetching #515

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

mpcen
Copy link
Member

@mpcen mpcen commented Mar 3, 2023

Calls to https://api.nuget.org/v3-flatcontainer/${spec.name}/${spec.revision}/${spec.name}.nuspec were failing when components contained uppercase chars thus marking them as "missing" when attempting to harvest.

This update lowercases all nuget component names before calling the nuget api

@mpcen mpcen requested a review from qtomlinson March 3, 2023 19:25
Copy link
Collaborator

@qtomlinson qtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good.

@mpcen mpcen merged commit 522a727 into master Mar 6, 2023
@mpcen mpcen deleted the mpcen/lowercasing-nuget-packagenames branch March 6, 2023 13:59
qtomlinson pushed a commit to qtomlinson/crawler that referenced this pull request Feb 6, 2024
…casing-nuget-packagenames

lowercasing package names for nuget api fetching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants