Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

ci: Add proxy env variables to crio service. #965

Closed

Conversation

jcvenegas
Copy link
Contributor

Check proxy env variables are set and add them to
the crio service.

  • Generate the crio service.

Fixes: #964

Signed-off-by: Jose Carlos Venegas Munoz jose.carlos.venegas.munoz@intel.com

Check proxy env variables are set and add them to
the crio service.

- Generate the crio service.

Fixes: clearcontainers#964

Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
Copy link
Contributor

@chavafg chavafg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jodh-intel
Copy link
Contributor

jodh-intel commented Apr 4, 2018

lgtm

Approved with PullApprove

@jodh-intel
Copy link
Contributor

The metrics CI is failing due to:

open results/network-bwd-host-contr-receiver.csv: no such file or directory

/cc @grahamwhaley.

@grahamwhaley
Copy link
Contributor

Indeed @jodh-intel. If you look further back up the logs you will find:

12:09:59 ERROR: iperf server init fails

which directly relates to #960 where I diagnosed and explained the problem.
Until/unless somebody explains and justifies the change in the mount of /dev/shm to a 9p mount, then I don't see this as a metrics test failure - I see it as a break in our shm mount. Nobody has explained yet. Until we have settled what is the right thing to do with shm (and possibly other tmpfs/ramfs mounts), then I'm afriad this test, and thus the metrics, is going to remain broken...
/cc @sboeuf @amshinde .

(Vaguely related is kata-containers/kata-containers#21 I would say as well)

@jcvenegas jcvenegas closed this May 30, 2018
mcastelino pushed a commit to mcastelino/tests that referenced this pull request Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants