This repository has been archived by the owner on May 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamwhaley
approved these changes
Feb 6, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
and thanks for adding the git clean
as well.
kubernetes qa-failed 👎 |
the CI is not passing... |
jcvenegas
force-pushed
the
jenkins_force_fetch
branch
from
February 6, 2018 19:23
054ae4c
to
b9a49a3
Compare
@chavafg @grahamwhaley any idea?
|
kubernetes qa-failed 👎 |
jcvenegas
force-pushed
the
jenkins_force_fetch
branch
from
February 6, 2018 19:55
b9a49a3
to
eaed2b3
Compare
kubernetes qa-failed 👎 |
If a PR was updated with a push force. We need to force to update the brach to test this commit does: - clean current branch. - If testing a PR, force to fetch and pull a brach with latest changes. Fixes: clearcontainers#894 Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
mcastelino
pushed a commit
to mcastelino/tests
that referenced
this pull request
Jan 23, 2019
To get the proper docker version to install, we need to now use `apt-cache madison` since `apt-cache show` is throwing an error. Fixes: clearcontainers#895. Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a PR was updated with a push force. We need to force
to update the brach to test this commit does:
Fixes: #894
Signed-off-by: Jose Carlos Venegas Munoz jose.carlos.venegas.munoz@intel.com