This repository has been archived by the owner on May 6, 2020. It is now read-only.
checkcommits: allow subsystem to overide need for "Fixes #XXX" #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodh-intel
changed the title
This was referenced Jan 19, 2018
jodh-intel
force-pushed
the
checkcommits-ignore-release-prs
branch
from
b383433
to
87808ba
Compare
|
kubernetes qa-passed 👍 |
1 similar comment
|
kubernetes qa-passed 👍 |
jcvenegas
approved these changes
Jan 19, 2018
cmd/checkcommits/checkcommits.go
Outdated
| } | ||
|
|
||
| // match 1 is the entire matching string | ||
| // match 2 is the subsystem name (without the colon) | ||
| subsystem = matches[1] |
There was a problem hiding this comment.
accorinding to the comment, dont you need matches[2]?
There was a problem hiding this comment.
Good question. Those comments were supposed to refer to "1st" and "2nd", but I've changed it to make it clearer. Thanks!
Fixed a comment error and updated copyright year. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Move the cli action code to a separate function to make the code cleaner. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Reworked to retrieve the commit details from `git(1)` before applying checks to the commit details. Previously, the "get" and "check" code was somewhat intermingled meaning it was not possible to apply tests to the overall commit (for example a check that spanned a commit subject *and* commit body). Initialised vendoring for assert package. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Add a new `--ignore-fixes-for-subsystem=` option that if specified will disable the effect of `--need-fixes` for those branches containing atleast one commit with the specified subsystem. The most useful scenario for this option being to allow a release PR (subsystem "`release: ...`") to not require an issue to be raised for it. Fixes clearcontainers#820. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel
force-pushed
the
checkcommits-ignore-release-prs
branch
from
87808ba
to
e7d09b9
Compare
|
kubernetes qa-passed 👍 |
|
would be nice to have support for |
|
lgtm
|
mcastelino
pushed a commit
to mcastelino/tests
that referenced
this pull request
Jan 23, 2019
Now that kata-containers/runtime#852 has been merged, we need to test docker integration tests with ipvlan driver with l2 and l3 mode. Fixes clearcontainers#861 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
--ignore-fixes-for-subsystem=option that if specified willdisable the effect of
--need-fixesfor those branches containing atleast onecommit with the specified subsystem.
The most useful scenario for this option being to allow a release PR
(subsystem "
release: ...") to not require an issue to be raised for it.Fixes #820.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com