-
Notifications
You must be signed in to change notification settings - Fork 18
checkcommits: allow subsystem to overide need for "Fixes #XXX" #861
checkcommits: allow subsystem to overide need for "Fixes #XXX" #861
Conversation
b383433
to
87808ba
Compare
kubernetes qa-passed 👍 |
1 similar comment
kubernetes qa-passed 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding this !looks good , just one question...
cmd/checkcommits/checkcommits.go
Outdated
} | ||
|
||
// match 1 is the entire matching string | ||
// match 2 is the subsystem name (without the colon) | ||
subsystem = matches[1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accorinding to the comment, dont you need matches[2]?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. Those comments were supposed to refer to "1st" and "2nd", but I've changed it to make it clearer. Thanks!
Fixed a comment error and updated copyright year. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Move the cli action code to a separate function to make the code cleaner. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Reworked to retrieve the commit details from `git(1)` before applying checks to the commit details. Previously, the "get" and "check" code was somewhat intermingled meaning it was not possible to apply tests to the overall commit (for example a check that spanned a commit subject *and* commit body). Initialised vendoring for assert package. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Add a new `--ignore-fixes-for-subsystem=` option that if specified will disable the effect of `--need-fixes` for those branches containing atleast one commit with the specified subsystem. The most useful scenario for this option being to allow a release PR (subsystem "`release: ...`") to not require an issue to be raised for it. Fixes clearcontainers#820. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
87808ba
to
e7d09b9
Compare
kubernetes qa-passed 👍 |
would be nice to have support for |
Now that kata-containers/runtime#852 has been merged, we need to test docker integration tests with ipvlan driver with l2 and l3 mode. Fixes clearcontainers#861 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
Add a new
--ignore-fixes-for-subsystem=
option that if specified willdisable the effect of
--need-fixes
for those branches containing atleast onecommit with the specified subsystem.
The most useful scenario for this option being to allow a release PR
(subsystem "
release: ...
") to not require an issue to be raised for it.Fixes #820.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com