This repository has been archived by the owner on May 6, 2020. It is now read-only.
scripts: Fix collect script bug URL #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct the URL displayed when the user runs
`{cc|kata}-collect-data.sh -h`.
Fixes clearcontainers#971.
Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Show bug URL when user runs `make help`. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
grahamwhaley
approved these changes
Jan 30, 2018
|
|
||
| # build type for Kata Containers | ||
| KATA_TYPE = kata | ||
|
|
||
| KATA_PROJECT_NAME = Kata Containers | ||
| KATA_PROJECT_TAG = kata-containers | ||
| KATA_PROJECT_URL = https://github.com/kata-containers | ||
| KATA_BUG_URL = $(KATA_PROJECT_URL)/kata-containers/issues/new |
There was a problem hiding this comment.
I guess that is in theory the best, most generic and neutral, URL we have. Shame 'orgs' don't have an Issues section on github.
There was a problem hiding this comment.
Yeah. I suspect we'll end up with a bunch of issues both at this URL and at the runtime one but from a triage perspective, it would be good if we could get them reported in the "main" repo as defined here.
|
kubernetes qa-passed 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the URL displayed when the user runs
{cc|kata}-collect-data.sh -h.Fixes #971.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com