Revert: Undo "Merge pull request #587 from mcastelino/topic/govet"

This reverts commit 535be19, reversing
changes made to 7e2466d.

This change broke the Jenkins CI and local unit-test builds (unable to
run them with either go 1.8 or go 1.9).

Fixes #615.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>

create_test.go

@@ -324,7 +324,7 @@ func TestCreateInvalidArgs(t *testing.T) {
 
 	for i, d := range data {
 		err := create(d.containerID, d.bundlePath, d.console, d.pidFilePath, d.detach, d.runtimeConfig)
-		assert.Errorf(err, "test %d (%+v)", i, d)
+		assert.Error(err, "test %d (%+v)", i, d)
 	}
 }
 
@@ -367,7 +367,7 @@ func TestCreateInvalidConfigJSON(t *testing.T) {
 
 	for detach := range []bool{true, false} {
 		err := create(testContainerID, bundlePath, testConsole, pidFilePath, true, runtimeConfig)
-		assert.Errorf(err, "%+v", detach)
+		assert.Error(err, "%+v", detach)
 		assert.False(vcMock.IsMockError(err))
 	}
 }
@@ -414,7 +414,7 @@ func TestCreateInvalidContainerType(t *testing.T) {
 
 	for detach := range []bool{true, false} {
 		err := create(testContainerID, bundlePath, testConsole, pidFilePath, true, runtimeConfig)
-		assert.Errorf(err, "%+v", detach)
+		assert.Error(err, "%+v", detach)
 		assert.False(vcMock.IsMockError(err))
 	}
 }
@@ -462,7 +462,7 @@ func TestCreateContainerInvalid(t *testing.T) {
 
 	for detach := range []bool{true, false} {
 		err := create(testContainerID, bundlePath, testConsole, pidFilePath, true, runtimeConfig)
-		assert.Errorf(err, "%+v", detach)
+		assert.Error(err, "%+v", detach)
 		assert.False(vcMock.IsMockError(err))
 	}
 }
@@ -637,7 +637,7 @@ func TestCreateCreateCgroupsFilesFail(t *testing.T) {
 
 	for detach := range []bool{true, false} {
 		err := create(testContainerID, bundlePath, testConsole, pidFilePath, true, runtimeConfig)
-		assert.Errorf(err, "%+v", detach)
+		assert.Error(err, "%+v", detach)
 		assert.False(vcMock.IsMockError(err))
 	}
 }
@@ -713,7 +713,7 @@ func TestCreateCreateCreatePidFileFail(t *testing.T) {
 
 	for detach := range []bool{true, false} {
 		err := create(testContainerID, bundlePath, testConsole, pidFilePath, true, runtimeConfig)
-		assert.Errorf(err, "%+v", detach)
+		assert.Error(err, "%+v", detach)
 		assert.False(vcMock.IsMockError(err))
 	}
 }
@@ -839,7 +839,7 @@ func TestCreateInvalidKernelParams(t *testing.T) {
 
 	for detach := range []bool{true, false} {
 		err := create(testContainerID, bundlePath, testConsole, pidFilePath, true, runtimeConfig)
-		assert.Errorf(err, "%+v", detach)
+		assert.Error(err, "%+v", detach)
 		assert.False(vcMock.IsMockError(err))
 	}
 }

main_test.go

@@ -648,7 +648,7 @@ func TestMainBeforeSubCommands(t *testing.T) {
 		err := beforeSubcommands(ctx)
 
 		if d.expectError {
-			assert.Errorf(err, "test %d (%+v)", i, d)
+			assert.Error(err, "test %d (%+v)", i, d)
 		} else {
 			assert.NoError(err, "test %d (%+v)", i, d)
 		}

run_test.go

@@ -151,7 +151,7 @@ func TestRunInvalidArgs(t *testing.T) {
 
 	for i, a := range args {
 		err := run(a.containerID, a.bundle, a.console, a.consoleSocket, a.pidFile, a.detach, a.runtimeConfig)
-		assert.Errorf(err, "test %d (%+v)", i, a)
+		assert.Error(err, "test %d (%+v)", i, a)
 	}
 }