Plugin whitelist

[pedro-rosario]

Whitelist to skip plugin auth

Plugins can also be objects now so they can pass metadata to amphora like a routes whitelist.

...
plugins: [
  ...,
  amphoraSearchPlugin,
  { init: testPluginFunction, whitelist: ['/_test-route'] };
],
...

This allows amphora to know which routes should skip the authentication

TODO

• Update plugins documentation
• Memoization of the route check

Closes #640

[coveralls]

Pull Request Test Coverage Report for Build 2199

• 42 of 42 (100.0%) changed or added relevant lines in 4 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 100.0%

---

Totals
Change from base Build 2184:	0.0%
Covered Lines:	4518
Relevant Lines:	4518

---

💛 - Coveralls

[manuelurenah]

Can we cache the function that's being tested so we don't have to call lib.getWhitelistFromPlugins in every test case?

describe('getWhitelistFromPlugins', function () {
  const fn = lib[this.title];

  it('returns an array of all the plugin\'s whitelist combined', function () {
    // ...

    expect(fn(plugins)).to.eql(['/_test']);
  });
});

Do this for every test suite

[manuelurenah]

Same suggestion as before

[pedro-rosario]

Closing this since the approach is not what we are interested in at the moment.