Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

master branch wash up #72

Closed
wants to merge 17 commits into from
Closed

master branch wash up #72

wants to merge 17 commits into from

Conversation

coelner
Copy link
Contributor

@coelner coelner commented Nov 1, 2020

#53
#71 only example draft, solution uprising
#61

anything forgotten?

@coelner coelner marked this pull request as ready for review December 12, 2020 07:24
@coelner coelner marked this pull request as draft January 4, 2021 20:39
@coelner
Copy link
Contributor Author

coelner commented Jan 5, 2021

BH1750/examples/BH1750two_i2c/BH1750two_i2c.ino

Line 57 in d2cfba6

if (lround(light_level_a) == -1) {

any reason why there is lround used? 🤔
if (light_level_a) == -1.0) {
would it be better?

@coelner coelner marked this pull request as ready for review May 7, 2021 15:08
@coelner coelner marked this pull request as draft October 13, 2021 15:40
schaeferpm and others added 14 commits October 13, 2021 20:48
@coelner
Copy link
Contributor Author

coelner commented Oct 13, 2021 •
edited
Loading

I think the issues are solved

@coelner coelner closed this Oct 13, 2021
@coelner coelner deleted the master branch October 14, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coelner @schaeferpm @mike-kiwi @claws