Non blocking #69
Merged
Non blocking #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various cleanups
claws
reviewed
Aug 23, 2020
claws
reviewed
Aug 23, 2020
claws
reviewed
Sep 11, 2020
claws
reviewed
Sep 11, 2020
claws
reviewed
Sep 11, 2020
|
Looks like there are a few minor format (mainly consistent indenting) issues remaining. |
|
I use a two whitespace indent and leave the |
coelner
force-pushed
the
nonBlocking
branch
from
eabe53f to
2a8adf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should address: #61 , #59 , #53
API Change for:
float readLightLevel();the parameter was removed. I estimate not really a problem here due it only should be used by people who had problems.@claws Could you please overlook this?