Use new react context! #624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also I moved the createContext call underneath all the import statements
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c5c1ce6:
|
|
Nice, thanks for taking this. I just don’t have bandwidth for it. Would love to see this library concurrent compatible, it’s the only thing holding us up at the moment! |
If this isn't done in the constructor, the manager value is initially undefined on first mount when trying to call this.context.manager.add in the register() method of SortableElement
|
@clauderic Can you please return to reviewing this? React Concurrent mode is getting closer every day =) |
|
Hi, any update on this PR? |
|
@clauderic Hi, how does it look like with the review? :) |
|
Is it possible to get this merged, if this will at least temporarily fix the |
Hypnosphi
added a commit
to Hypnosphi/awesome-react-components
that referenced
this pull request
Aug 5, 2020
[`react-sortable-hoc`](https://github.com/clauderic/react-sortable-hoc) is incompatible with future React versions, and its maintainers show no reaction to PR fixing this: clauderic/react-sortable-hoc#624 [`react-measure`](https://github.com/tajo/react-movable) is an accessible, low-sized, and well-maintained alternative
|
Can anyone merge this, please? My console is full of "Legacy context API has been detected within a strict-mode tree" warnings. |
|
Hello, I'm getting a ton of the legacy API warnings. Are there any plans to merge this to fix them? Thanks! |
|
Hi @clauderic when will this PR be merged or will it not be merged? |
toptaldev92
pushed a commit
to toptaldev92/awesome-react-components
that referenced
this pull request
Jul 29, 2021
[`react-sortable-hoc`](https://github.com/clauderic/react-sortable-hoc) is incompatible with future React versions, and its maintainers show no reaction to PR fixing this: clauderic/react-sortable-hoc#624 [`react-measure`](https://github.com/tajo/react-movable) is an accessible, low-sized, and well-maintained alternative
KeepGrowingHere
pushed a commit
to KeepGrowingHere/awesome-react-components
that referenced
this pull request
May 9, 2023
[`react-sortable-hoc`](https://github.com/clauderic/react-sortable-hoc) is incompatible with future React versions, and its maintainers show no reaction to PR fixing this: clauderic/react-sortable-hoc#624 [`react-measure`](https://github.com/tajo/react-movable) is an accessible, low-sized, and well-maintained alternative
devsoft0615
added a commit
to devsoft0615/React_Component
that referenced
this pull request
Jun 20, 2023
[`react-sortable-hoc`](https://github.com/clauderic/react-sortable-hoc) is incompatible with future React versions, and its maintainers show no reaction to PR fixing this: clauderic/react-sortable-hoc#624 [`react-measure`](https://github.com/tajo/react-movable) is an accessible, low-sized, and well-maintained alternative
aleksandaralek
added a commit
to aleksandaralek/awesome-react-components
that referenced
this pull request
Oct 24, 2023
[`react-sortable-hoc`](https://github.com/clauderic/react-sortable-hoc) is incompatible with future React versions, and its maintainers show no reaction to PR fixing this: clauderic/react-sortable-hoc#624 [`react-measure`](https://github.com/tajo/react-movable) is an accessible, low-sized, and well-maintained alternative
Victory0611
added a commit
to Victory0611/awesome-components
that referenced
this pull request
Mar 9, 2024
[`react-sortable-hoc`](https://github.com/clauderic/react-sortable-hoc) is incompatible with future React versions, and its maintainers show no reaction to PR fixing this: clauderic/react-sortable-hoc#624 [`react-measure`](https://github.com/tajo/react-movable) is an accessible, low-sized, and well-maintained alternative
GoldenPlayBoy
added a commit
to GoldenPlayBoy/test
that referenced
this pull request
Jul 4, 2024
[`react-sortable-hoc`](https://github.com/clauderic/react-sortable-hoc) is incompatible with future React versions, and its maintainers show no reaction to PR fixing this: clauderic/react-sortable-hoc#624 [`react-measure`](https://github.com/tajo/react-movable) is an accessible, low-sized, and well-maintained alternative
principlesoftware-dev
pushed a commit
to principlesoftware-dev/react-awesome-components
that referenced
this pull request
Aug 25, 2024
[`react-sortable-hoc`](https://github.com/clauderic/react-sortable-hoc) is incompatible with future React versions, and its maintainers show no reaction to PR fixing this: clauderic/react-sortable-hoc#624 [`react-measure`](https://github.com/tajo/react-movable) is an accessible, low-sized, and well-maintained alternative
rey0601
pushed a commit
to rey0601/awesome-react-components
that referenced
this pull request
Jun 4, 2025
[`react-sortable-hoc`](https://github.com/clauderic/react-sortable-hoc) is incompatible with future React versions, and its maintainers show no reaction to PR fixing this: clauderic/react-sortable-hoc#624 [`react-measure`](https://github.com/tajo/react-movable) is an accessible, low-sized, and well-maintained alternative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued the work of @natew
Also I moved the createContext call underneath all the import statements because my vscode was complaining about that.