Add Font Color Setting #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I checked the PR and the "Highlight Font Color" setting exists and the decorator uses the font color as expected. |
|
@parithon do you have access to approve and merge now? |
clarkio
added
help wanted
parithon
approved these changes
Feb 14, 2019
clarkio
added a commit
that referenced
this pull request
Mar 1, 2019
* init 0.1.4 * add changelog with details (#59) * Add Font Color Setting (#55) ### Purpose These changes add a new setting that allows users to define the color of the font within a highlight. This comes as a result from the following issue raided by @corbob: #53 - Addresses: #53 ### Files Changed - `extension.ts`: add use of `color` key in decoration type setup which is read from settings or defaults to `white` - `package.json`: defined new setting for font color so that it is available to users - `README.md`: update documentation to reflect the new setting option and changelog details ### How to Test - Run in terminal/command line: `git clone https://github.com/clarkio/vscode-twitch-highlighter.git` - Run in terminal/command line: `cd vscode-twitch-highlighter && npm install` - Press F5 or click debug button (green triangle/play button) - Create a highlight to see the result ### What to Validate - Make sure the visible font color of a highlight is defaulting to white - Open settings in Extension Host instance of VS Code and make sure there is a setting available called "Highlight Font Color" (search for "Twitch Color"). - After changing the default font color to something other than white (such as "red") create a new highlight and confirm the font color in the highlight is now red * Client refactor (#57) The extension.ts document is getting unwieldy and needs some refactoring. I refactored the language client out of the extension.ts document into its own class in `twitchLanguageClient.ts`. Additionally, I renamed the `server.ts` to `twitchLanguageServer.ts` to better identify its purpose. Finally, I also cleaned up the unnecessary functions in `credentialManager.ts` and fixed the camel casing of the `twitchHighlighterTreeView.ts` which causes Linux to fail during a build. (e.g. casing matters on Linux) * added category string in package.json (#63) As stated [here](https://code.visualstudio.com/api/references/contribution-points#contributes.commands) in the VS Code documentation on contribution points, you can "define a category string which will prefix the command title and allow easy grouping within the Command Palette drop-down." I'm not sure if this is something that you guys want, but it makes it so you don't have to repeat the `Twitch Highlighter:` part of the command title. Grouping of the commands may make it look nicer in the command palette. * update docs * add ci/cd build instructions * Added some arbitrary tests * Removed Glitch from our icons * Using Webpack to reduce our extension size * add updates with prs to changelog * move 0.1.4 to released section and start 0.1.5 unreleased section * update tags to each version for comparisons * Comments and Multi-line Highlight Support * Add unhighlight on disconnect * Change `channels` setting to a string (#76) * Change `channels` setting to a string * Trim the channels for whitespaces * Updated README.md (#75) ...to include the DevOps badges from Azure and some images. * prep for 0.1.5 release * fix up docs on channels setting and package description
clarkio
added a commit
that referenced
this pull request
Mar 6, 2019
* init 0.1.4 * add changelog with details (#59) * Add Font Color Setting (#55) ### Purpose These changes add a new setting that allows users to define the color of the font within a highlight. This comes as a result from the following issue raided by @corbob: #53 - Addresses: #53 ### Files Changed - `extension.ts`: add use of `color` key in decoration type setup which is read from settings or defaults to `white` - `package.json`: defined new setting for font color so that it is available to users - `README.md`: update documentation to reflect the new setting option and changelog details ### How to Test - Run in terminal/command line: `git clone https://github.com/clarkio/vscode-twitch-highlighter.git` - Run in terminal/command line: `cd vscode-twitch-highlighter && npm install` - Press F5 or click debug button (green triangle/play button) - Create a highlight to see the result ### What to Validate - Make sure the visible font color of a highlight is defaulting to white - Open settings in Extension Host instance of VS Code and make sure there is a setting available called "Highlight Font Color" (search for "Twitch Color"). - After changing the default font color to something other than white (such as "red") create a new highlight and confirm the font color in the highlight is now red * Client refactor (#57) The extension.ts document is getting unwieldy and needs some refactoring. I refactored the language client out of the extension.ts document into its own class in `twitchLanguageClient.ts`. Additionally, I renamed the `server.ts` to `twitchLanguageServer.ts` to better identify its purpose. Finally, I also cleaned up the unnecessary functions in `credentialManager.ts` and fixed the camel casing of the `twitchHighlighterTreeView.ts` which causes Linux to fail during a build. (e.g. casing matters on Linux) * added category string in package.json (#63) As stated [here](https://code.visualstudio.com/api/references/contribution-points#contributes.commands) in the VS Code documentation on contribution points, you can "define a category string which will prefix the command title and allow easy grouping within the Command Palette drop-down." I'm not sure if this is something that you guys want, but it makes it so you don't have to repeat the `Twitch Highlighter:` part of the command title. Grouping of the commands may make it look nicer in the command palette. * update docs * add ci/cd build instructions * Added some arbitrary tests * Removed Glitch from our icons * Using Webpack to reduce our extension size * add updates with prs to changelog * move 0.1.4 to released section and start 0.1.5 unreleased section * update tags to each version for comparisons * Comments and Multi-line Highlight Support * Add unhighlight on disconnect * Change `channels` setting to a string (#76) * Change `channels` setting to a string * Trim the channels for whitespaces * Updated README.md (#75) ...to include the DevOps badges from Azure and some images. * prep for 0.1.5 release * fix up docs on channels setting and package description * Added a test theory for our bot command * Solves Issue 78 * prep for 0.2.0 * update the why on connect/disconnect button move
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
These changes add a new setting that allows users to define the color of the font within a highlight. This comes as a result from the following issue raided by @corbob: #53
Files Changed
extension.ts: add use ofcolorkey in decoration type setup which is read from settings or defaults towhitepackage.json: defined new setting for font color so that it is available to usersREADME.md: update documentation to reflect the new setting option and changelog detailsHow to Test
git clone https://github.com/clarkio/vscode-twitch-highlighter.gitcd vscode-twitch-highlighter && npm installWhat to Validate