Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start/Stop Chat button status shows connecting if you cancel the 'Set token' prompt #82

Closed
parithon opened this issue Mar 2, 2019 · 1 comment
Closed

Start/Stop Chat button status shows connecting if you cancel the 'Set token' prompt #82

parithon opened this issue Mar 2, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@parithon
Copy link
Collaborator

parithon commented Mar 2, 2019

As mentioned in the title, the start/stop chat button' status doesn't change back to 'Disconnected' from 'Connecting...' when the user cancels the 'Set token' prompt. If the user cancels the 'set token' prompt the status should change from 'Connecting...' to 'Disconnected' as the connection process was terminated.
@parithon parithon added the bug Something isn't working label Mar 2, 2019
@parithon parithon mentioned this issue Mar 16, 2019
Merged
clarkio pushed a commit that referenced this issue Apr 12, 2019
@parithon @clarkio
Solves issue #82 - Status bar shows inaccurate status if you cancel s…
8958986 
…etting token when connecting (#91)

### Purpose

Solves issue #82 whereby the status bar button changes to 'Connecting...' prior to ensuring a token is set. When a user cancels the connection prior to entering the token the 'Connecting...' status never changes back to 'Disconnected'.

### Changed files

- `twitchChatClient.ts` Moved the 'token' sanity check prior to updating the status and starting the connection to the twitch client.

### Addresses

#82
@parithon
Copy link
Collaborator Author

Bug fixed from PR #91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@parithon