Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize Invite length #19

Closed
wants to merge 2 commits into from
Closed

Customize Invite length #19

wants to merge 2 commits into from

Conversation

m1guelpf
Copy link
Contributor

@m1guelpf m1guelpf commented May 1, 2017

No description provided.

@m1guelpf m1guelpf mentioned this pull request May 1, 2017
@codecov-io
Copy link

codecov-io commented May 1, 2017

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #19   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity       48     48           
=======================================
  Files             7      7           
  Lines           125    125           
=======================================
  Hits            125    125
Impacted Files Coverage Δ Complexity Δ
src/Generator.php 100% <100%> (ø) 9 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b46fcbf...acb756e. Read the comment docs.

@m1guelpf
Copy link
Contributor Author

m1guelpf commented May 1, 2017

@clarkeash Codecov says the coverage doesn't change... so does it need tests?

@clarkeash
Copy link
Owner

Hi @m1guelpf thanks for your work on this but I am not going to merge it as this will be handled differently. I am working on the code to support #17 which will allow configuration on a driver basis. see the config file - This branch is still in development so things may change.

@clarkeash clarkeash closed this May 3, 2017
@m1guelpf m1guelpf deleted the patch-2 branch May 4, 2017 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants