Fixed smear3 to work with newer numpy versions #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
==========================================
- Coverage 92.86% 92.86% -0.01%
==========================================
Files 43 43
Lines 3924 3923 -1
==========================================
- Hits 3644 3643 -1
Misses 280 280
☔ View full report in Codecov by Sentry. |
|
@groadabike this fixes the numpy 1.25 and 1.26 issues |
|
That's great, thank you for this.
…On Sun, 17 Sept 2023, 18:58 Jon Barker, ***@***.***> wrote:
@groadabike <https://github.com/groadabike> this fixes the numpy 1.25 and
1.26 issues
—
Reply to this email directly, view it on GitHub
<#346 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AED2G2SUARD46Z7QZWJR6NLX2423NANCNFSM6AAAAAA43YDEUE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
jonbarker68
deleted the
345-bug-smearer-tests-are-failing-when-using-numpy-125-or-later
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the problem that was causing some tests to fail with the newer numpy versions.