-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clap_complete): Support flags with values --flag bar
and -f bar
in native completions
#5539
Conversation
30d127b
to
d55ea23
Compare
05ab44a
to
456053d
Compare
4c6e44b
to
46dcc90
Compare
--flag bar
and -f bar
completion
The cases of -fbar and -f=bar have not been handled yet. |
I have added support for clap/clap_complete/src/dynamic/completer.rs Lines 141 to 146 in 469d847
This code didn't consider the case -f=bar[TAB] , so it could generate -f=barf in completions. I will fix it later.
|
While talked about this in the call, to not lose track of this
Please split that out into another branch for a later PR so we can focus on getting the current PR merged. |
--flag bar
and -f bar
in native completions
related issue: #3920
what is left
-fbar
and-f=bar
--flag=bar
in bashfoo --bar\t
offering both--bar <value>
and--bare