fix!: Require explicit help/version disabling #4056
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we introduced actions, it required specific setups to engage with
claps version and help printing. With actions making that more
explicit, we don't get as much benefit from our multiple, obscure, ways
of users customizing help
Before
mut_arg
which wouldautomatically be pushed down the command tree like
global(true)
built-in on (I think)
automatically disabled
they want
Now
mut_arg
no longer works as we define help and version flags at theend
long, or short, a debug assert will tell them to explicitly disable
the built-in
propagate through the command tree, they need to set
global(true)
.Benefits
behavior. Someone creates an arg and we then tell them how to disable
the built-in
responsibility onto the developer in what are hopefully just corner
cases
Fixes #3405
Fixes #4033