Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy cleanup #4683

Closed
2 tasks done
martinfrances107 opened this issue Jan 29, 2023 · 1 comment
Closed
2 tasks done

Clippy cleanup #4683

martinfrances107 opened this issue Jan 29, 2023 · 1 comment
Labels
C-enhancement Category: Raise on the bar on expectations

Comments

@martinfrances107
Copy link
Contributor

Please complete the following tasks

Clap Version

master

Describe your use case

When I run cargo clippy on this project .. There are too many issues for a human to scan.

A recent clippy rule ... It is now suggesting change of this form

-            println!("Diffing {}..{} {} (color={})", base, head, path, color);
+            println!("Diffing {base}..{head} {path} (color={color})");

This project has about 100 of these warnings ... I just want to cut the list down so I can scan other results.

Describe the solution you'd like

By targeting on rule, I hope this make the review process easy.

Alternatives, if applicable

Should I fix all other clippy issues?

My feeling on that is no with so many other PR on this project it would be disputive

Additional Context

No response

@martinfrances107 martinfrances107 added the C-enhancement Category: Raise on the bar on expectations label Jan 29, 2023
@epage
Copy link
Member

epage commented Jan 30, 2023

Closing as this is something we do not need to track in an issue. We enforce that there are no clippy lints for a specific version of rustc (our MSRV). There will always be new lints being reported with each version of rustc being released and it isn't worth tracking this as an issue each time.

@epage epage closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2023
epage added a commit that referenced this issue Jan 30, 2023
#4683 Clippy: make format!() calls more readable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Raise on the bar on expectations
Projects
None yet
Development

No branches or pull requests

2 participants